fix: Porting throwError function for proper error handling of parseUrl #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshwata
commented
Mar 7, 2022
index.js
Outdated
| @@ -346,6 +359,16 @@ class GitlabScm extends Scm { | |||
| token | |||
| }) | |||
| .then(response => { | |||
| if (response.statusCode === 404) { | |||
| throwError(`Cannot find repository ${checkoutUrl}`, response.statusCode); | |||
| } | |||
There was a problem hiding this comment.
When the statusCode is 404, error object is thrown with statusCode as result of runCommand, so no need to add this line.
yoshwata
commented
Mar 7, 2022
index.js
Outdated
| `STATUS CODE ${response.statusCode}: ${JSON.stringify(response.body)}`, | ||
| response.statusCode | ||
| ); | ||
| } |
There was a problem hiding this comment.
That might be a situation that should not be error on 2xx, so I remove this block.
|
Could you test that the Lines 260 to 262 in 05c4498 |
Thank you. I added a test. |
y-oksaku
approved these changes
Mar 7, 2022
tkyi
approved these changes
Mar 7, 2022
|
🎉 This PR is included in version 2.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Port the throwError function from scm-github so that the error handling of parseUrl can be done normally.
https://github.com/screwdriver-cd/scm-github/blob/e554b40619b8530d0eadc9ac02f35e3826900ff0/index.js#L57
Objective
Error handling of parseUrl is successful
References
screwdriver-cd/screwdriver#2674
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.